Re: [PATCH v5 01/22] kho: generalize radix tree APIs

[Pratyush Yadav]

On Thu, Jul 30 2026, Mike Rapoport wrote:

> On Wed, Jul 29, 2026 at 04:55:46PM +0200, Pratyush Yadav wrote:
>> From: "Pratyush Yadav (Google)" <pratyush@xxxxxxxxxx>
>> 
>> Generalize the APIs by taking the key directly and doing the encoding at
>> the callers. Rename the functions to kho_radix_add_key() and
>> kho_radix_del_key(). In practice, this removes a line each from the
>> functions and moves the encoding function call to the callers.
>> Similarly, update kho_radix_tree_walk_callback_t to take the key
>> directly.
>>
>> diff --git a/include/linux/kho_radix_tree.h b/include/linux/kho_radix_tree.h
>> index 84e918b96e53..f368f3b9f923 100644
>> --- a/include/linux/kho_radix_tree.h
>> +++ b/include/linux/kho_radix_tree.h
>> @@ -34,30 +34,24 @@ struct kho_radix_tree {
>>  	struct mutex lock; /* protects the tree's structure and root pointer */
>>  };
>
> sashiko: This isn't a bug, but did you miss updating the kerneldoc for
> struct kho_radix_tree?

That's new, sashiko didn't find this on v4...

>
> And indeed "DOC: Kexec Handover Radix Tree" talks about addresses and
> orders.

Yep, will fix for v6.

-- 
Regards,
Pratyush Yadav