Re: [PATCH v2 1/3] can: rockchip_canfd: prevent TX stall on echo skb failure

[Cunhao Lu]

Hi Marc,

On 30.07.2026, Marc Kleine-Budde wrote:
> Can you update can_put_echo_skb() to always free the skb in the error case?

Yes. In v3, I will update can_put_echo_skb() to also free the skb on
-EINVAL, so that it consistently consumes the skb on every error path.
I will remove the corresponding -EINVAL special case from the Rockchip
CAN-FD driver.

> Is this error message needed? In the -EINVAL case can_put_echo_skb()
> already emits an error. If skb allocation I think in -ENOMEM case the
> kernel already throws an error, right?

Agreed. The additional driver error message is redundant. I will remove
it in v3 and retain only the dropped-frame accounting and error handling.

Thanks for the review.

Best regards,
Cunhao