Re: [PATCH] net: stmmac: Avoid freeing and re-requesting IRQ during XDP set prog

[Andrew Lunn]

> After review I found that moving the disable to stmmac_xdp_release()
> does and removing the call the stmmac_init_chan() gets things most of
> the way there. After these changes every action in stmmac_xdp_release()
> can now be traced by to corresponding restore code in stmmac_xdp_open().

Great, thanks for finding time to look at this.

> It's not fully symmetric because activity in open does not appear in
> reverse order compared to release. However it definitely moves things
> in the right direction ....

We cannot expect stmmac to be fixed all at once, it has too many
issues. Maybe we can ask developers who need to touch some code to
spend a little bit of time to also do some fixup in that area. So we
slowly chip away at the problems.

Thanks
	Andrew