Re: [PATCH] arm64: dts: qcom: sm8250-xiaomi-elish: correct the board ID

[Dmitry Baryshkov]

On Thu, Jul 30, 2026 at 03:44:07PM +0200, Dawid Wróbel via B4 Relay wrote:
> From: Dawid Wróbel <me@xxxxxxxxxxxxxxx>
> 
> elish declares the same qcom,msm-id and qcom,board-id pair as
> sm8250-sony-xperia-edo.dtsi, so a bootloader choosing between appended
> device trees cannot tell the two boards apart.
> 
> 0x10008 is Sony's value. The downstream device tree for this board,
> elish-sm8250-overlay.dts, uses qcom,board-id = <47 0>, i.e. platform
> type 0x2f.
> 
> Fixes: a41b617530bf ("arm64: dts: qcom: sm8250: Add device tree for Xiaomi Mi Pad 5 Pro")
> Signed-off-by: Dawid Wróbel <me@xxxxxxxxxxxxxxx>
> ---
> Not tested on elish hardware: the corrected value comes from the
> downstream device tree:
> https://github.com/LineageOS/android_kernel_xiaomi_sm8250/blob/a04dba03999b36cc8f472c014063395b41fb1022/arch/arm64/boot/dts/vendor/qcom/elish-sm8250-overlay.dts#L14
> 
> That import commit (bf5acbcaca99) credits Xiaomi's munch-s-oss and
> dagu-s-oss releases; Xiaomi's published kernel repo doesn't contain
> the device trees, so LineageOS seems to be the only public source.

DTs are in a separate repo, I believe.

> 
> No user-visible impact: nothing in the kernel reads qcom,board-id, and it
> is only consulted when a bootloader selects between several appended
> device trees. Not needed for stable.
> ---
>  arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>



-- 
With best wishes
Dmitry