Re: [PATCH] crypto: ccp - don't abuse kernel-doc comment format

[Tom Lendacky]

On 7/30/26 00:17, Randy Dunlap wrote:
> Use plain C "/*" notation for comments that are not in kernel-doc format
> to avoid kernel-doc warnings:
> 
> Warning: include/uapi/linux/psp-sfs.h:18 expecting prototype for SFS().
>  Prototype was for PAYLOAD_NAME_SIZE() instead
> Warning: include/uapi/linux/psp-sfs.h:46 This comment starts with '/**',
>  but isn't a kernel-doc comment.
>  * Seamless Firmware Support (SFS) IOC
> 
> Fixes: 648dbccc03a0 ("crypto: ccp - Add AMD Seamless Firmware Servicing (SFS) driver")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Acked-by: Tom Lendacky <thomas.lendacky@xxxxxxx>

> ---
> Cc: Ashish Kalra <ashish.kalra@xxxxxxx>
> Cc: Borislav Petkov (AMD) <bp@xxxxxxxxx>
> Cc: Tom Lendacky <thomas.lendacky@xxxxxxx>
> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: linux-crypto@xxxxxxxxxxxxxxx
> 
>  include/uapi/linux/psp-sfs.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-next-20260729.orig/include/uapi/linux/psp-sfs.h
> +++ linux-next-20260729/include/uapi/linux/psp-sfs.h
> @@ -12,7 +12,7 @@
>  
>  #include <linux/types.h>
>  
> -/**
> +/*
>   * SFS: AMD Seamless Firmware Support (SFS) interface
>   */
>  
> @@ -43,7 +43,7 @@ struct sfs_user_update_package {
>  	__u32	sfs_extended_status;
>  } __packed;
>  
> -/**
> +/*
>   * Seamless Firmware Support (SFS) IOC
>   *
>   * possible return codes for all SFS IOCTLs: