Re: [PATCH net 3/4] net: dsa: mt7530: error out on failed PHY_IAC command writes

[Andrew Lunn]

On Thu, Jul 30, 2026 at 05:03:29PM +0100, Daniel Golle wrote:
> MT7531_PHY_ACS_ST is only ever set by the command write that precedes
> each poll in the MT7531 indirect PHY access functions, and that
> write's return value is discarded. A failed write leaves ACS_ST at 0
> from the previous access, so the poll succeeds on its first iteration
> and the functions return stale IAC contents as if they were fresh PHY
> data. Check the writes and bail out before polling.
> 
> Fixes: c288575f7810 ("net: dsa: mt7530: Add the support of MT7531 switch")
> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew