Re: [PATCH net] rtnetlink: truncate IFLA_VFINFO_LIST instead of overflowing its length
From: Artem Lytkin
Date: Thu Jul 30 2026 - 14:16:18 EST
On Thu, Jul 30, 2026 at 02:17:35AM -0700, Jacob Keller wrote:
> I'd argue this is a "fix", as we were previously doing objectively the
> wrong thing by randomly truncating the message at arbitrary points.
Our mails crossed. v2 went out ten minutes before yours, taking Jakub's
128 and 256, documenting them in the netlink spec and dropping the tag:
https://lore.kernel.org/netdev/20260730090700.65867-1-iprintercanon@xxxxxxxxx/
I have no strong view on who is right, but the tag decides more than
bookkeeping here. With it this goes to net and gets backported, so an ice
PF with 256 VFs stops producing a corrupt link dump on a stable kernel;
without it that waits for the merge window. Against that, nothing
regressed: the interface has been able to write a length it cannot
represent since 2010, which I take to be Jakub's point.
Happy to restore the tag and resend against net if Jakub is persuaded.
Artem