RE: [EXTERNAL] [PATCH] net: prestera: validate firmware header length

[Elad Nachman]

>
>
> From: Pengpeng Hou <pengpeng@xxxxxxxxxxx>
> Sent: Monday, July 6, 2026 12:26 PM
> To: Elad Nachman <enachman@xxxxxxxxxxx>
> Cc: Pengpeng Hou <pengpeng@xxxxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [EXTERNAL] [PATCH] net: prestera: validate firmware header length
>
> prestera_fw_hdr_parse() reads the firmware header before checking that the firmware image contains that header. Reject images shorter than struct prestera_fw_header before decoding the magic and version fields. Signed-off-by: Pengpeng Hou <pengpeng@ iscas. ac. cn>
> prestera_fw_hdr_parse() reads the firmware header before checking
> that the firmware image contains that header.
>
> Reject images shorter than struct prestera_fw_header before decoding the
> magic and version fields.
>
> Signed-off-by: Pengpeng Hou <mailto:pengpeng@xxxxxxxxxxx>
> ---
>  drivers/net/ethernet/marvell/prestera/prestera_pci.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/marvell/prestera/prestera_pci.c b/drivers/net/ethernet/marvell/prestera/prestera_pci.c
> index 2989a77e3b42..1ad0e62a8433 100644
> --- a/drivers/net/ethernet/marvell/prestera/prestera_pci.c
> +++ b/drivers/net/ethernet/marvell/prestera/prestera_pci.c
> @@ -684,6 +684,9 @@ static int prestera_fw_hdr_parse(struct prestera_fw *fw)
>       struct prestera_fw_header *hdr;
>       u32 magic;
>
> +     if (fw->bin->size < sizeof(*hdr))
> +             return -EINVAL;
> +
>       hdr = (struct prestera_fw_header *)fw->bin->data;
>
>       magic = be32_to_cpu(hdr->magic_number);
> --
> 2.43.0
>

Please fix the subject line per Andrew's e-mail.
After that the patch can be approved, as the source code modification is OK.

Elad.