Re: [PATCH v2 1/2] platform/x86: oxpec: Distinguish OneXPlayer Super X board

[Antheas Kapenekakis]

On Tue, 28 Jul 2026 at 10:36, Alexander Egorov <begeebe@xxxxxxxxx> wrote:
>
> The Super X currently shares the oxp_g1_a board identifier because its
> existing EC functionality matches the G1 AMD.
>
> Give it a dedicated identifier so model-specific functionality can be
> selected without also enabling it on the G1. Preserve the existing G1
> AMD behavior for the new identifier.
>
> Assisted-by: Codex:gpt-5.6

Reviewed-by: Antheas Kapenekakis <lkml@xxxxxxxxxxx>

> Signed-off-by: Alexander Egorov <begeebe@xxxxxxxxx>
> ---
>  drivers/platform/x86/oxpec.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/oxpec.c b/drivers/platform/x86/oxpec.c
> index 99c0dfc..df29e41 100644
> --- a/drivers/platform/x86/oxpec.c
> +++ b/drivers/platform/x86/oxpec.c
> @@ -50,6 +50,7 @@ enum oxp_board {
>         oxp_x1,
>         oxp_g1_i,
>         oxp_g1_a,
> +       oxp_super_x,
>  };
>
>  static enum oxp_board board;
> @@ -210,7 +211,7 @@ static const struct dmi_system_id dmi_table[] = {
>                         DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
>                         DMI_EXACT_MATCH(DMI_BOARD_NAME, "ONEXPLAYER SUPER X"),
>                 },
> -               .driver_data = (void *)oxp_g1_a,
> +               .driver_data = (void *)oxp_super_x,
>         },
>         {
>                 .matches = {
> @@ -345,6 +346,7 @@ static umode_t tt_toggle_is_visible(struct kobject *kobj,
>         case oxp_x1:
>         case oxp_g1_i:
>         case oxp_g1_a:
> +       case oxp_super_x:
>                 return attr->mode;
>         default:
>                 break;
> @@ -374,6 +376,7 @@ static ssize_t tt_toggle_store(struct device *dev,
>         case oxp_fly:
>         case oxp_mini_amd_pro:
>         case oxp_g1_a:
> +       case oxp_super_x:
>                 reg = OXP_TURBO_SWITCH_REG;
>                 mask = OXP_TURBO_TAKE_VAL;
>                 break;
> @@ -420,6 +423,7 @@ static ssize_t tt_toggle_show(struct device *dev,
>         case oxp_fly:
>         case oxp_mini_amd_pro:
>         case oxp_g1_a:
> +       case oxp_super_x:
>                 reg = OXP_TURBO_SWITCH_REG;
>                 mask = OXP_TURBO_TAKE_VAL;
>                 break;
> @@ -516,6 +520,7 @@ static bool oxp_psy_ext_supported(void)
>         case oxp_x1:
>         case oxp_g1_i:
>         case oxp_g1_a:
> +       case oxp_super_x:
>         case oxp_fly:
>                 return true;
>         default:
> @@ -649,6 +654,7 @@ static int oxp_pwm_enable(void)
>         case oxp_x1:
>         case oxp_g1_i:
>         case oxp_g1_a:
> +       case oxp_super_x:
>                 return write_to_ec(OXP_SENSOR_PWM_ENABLE_REG, PWM_MODE_MANUAL);
>         default:
>                 return -EINVAL;
> @@ -669,6 +675,7 @@ static int oxp_pwm_disable(void)
>         case oxp_x1:
>         case oxp_g1_i:
>         case oxp_g1_a:
> +       case oxp_super_x:
>                 return write_to_ec(OXP_SENSOR_PWM_ENABLE_REG, PWM_MODE_AUTO);
>         default:
>                 return -EINVAL;
> @@ -689,6 +696,7 @@ static int oxp_pwm_read(long *val)
>         case oxp_x1:
>         case oxp_g1_i:
>         case oxp_g1_a:
> +       case oxp_super_x:
>                 return read_from_ec(OXP_SENSOR_PWM_ENABLE_REG, 1, val);
>         default:
>                 return -EOPNOTSUPP;
> @@ -725,6 +733,7 @@ static int oxp_pwm_fan_speed(long *val)
>         case oxp_mini_amd_a07:
>         case oxp_mini_amd_pro:
>         case oxp_g1_a:
> +       case oxp_super_x:
>                 return read_from_ec(OXP_SENSOR_FAN_REG, 2, val);
>         default:
>                 return -EOPNOTSUPP;
> @@ -757,6 +766,7 @@ static int oxp_pwm_input_write(long val)
>         case oxp_fly:
>         case oxp_mini_amd_pro:
>         case oxp_g1_a:
> +       case oxp_super_x:
>                 return write_to_ec(OXP_SENSOR_PWM_REG, val);
>         default:
>                 return -EOPNOTSUPP;
> @@ -796,6 +806,7 @@ static int oxp_pwm_input_read(long *val)
>         case oxp_fly:
>         case oxp_mini_amd_pro:
>         case oxp_g1_a:
> +       case oxp_super_x:
>         default:
>                 ret = read_from_ec(OXP_SENSOR_PWM_REG, 1, val);
>                 if (ret)
> --
> 2.55.0
>
>