RE: [EXTERNAL] [PATCH net-next v2 1/3] net: prestera: ignore duplicate RIF destruction events
From: Elad Nachman
Date: Thu Jul 30 2026 - 14:41:39 EST
>
>
> From: Yuyang Huang <yuyanghuang@xxxxxxxxxx>
> Sent: Saturday, July 11, 2026 3:54 AM
> To: Yuyang Huang <yuyanghuang@xxxxxxxxxx>
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>; David Ahern <dsahern@xxxxxxxxxx>; Elad Nachman <enachman@xxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Ido Schimmel <idosch@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Johannes Berg <johannes@xxxxxxxxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Simon Horman <horms@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>
> Subject: [EXTERNAL] [PATCH net-next v2 1/3] net: prestera: ignore duplicate RIF destruction events
>
> During address teardown, the inetaddr notifier may be called multiple
> times for the same interface. Ignore NETDEV_DOWN events if the RIF has
> already been destroyed, rather than returning -EEXIST, which aborts the
> notifier chain.
>
> Cc: Ido Schimmel <mailto:idosch@xxxxxxxxxx>
> Cc: Kuniyuki Iwashima <mailto:kuniyu@xxxxxxxxxx>
> Signed-off-by: Yuyang Huang <mailto:yuyanghuang@xxxxxxxxxx>
> ---
> drivers/net/ethernet/marvell/prestera/prestera_router.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/prestera/prestera_router.c b/drivers/net/ethernet/marvell/prestera/prestera_router.c
> index b036b173a308..0c4f462baa6e 100644
> --- a/drivers/net/ethernet/marvell/prestera/prestera_router.c
> +++ b/drivers/net/ethernet/marvell/prestera/prestera_router.c
> @@ -1302,10 +1302,8 @@ static int __prestera_inetaddr_port_event(struct net_device *port_dev,
> dev_hold(port_dev);
> break;
> case NETDEV_DOWN:
> - if (!re) {
> - NL_SET_ERR_MSG_MOD(extack, "Can't find RIF");
> - return -EEXIST;
> - }
> + if (!re)
> + return 0;
> prestera_rif_entry_destroy(port->sw, re);
> dev_put(port_dev);
> break;
> --
> 2.55.0.795.g602f6c329a-goog
>
Acked-by: Elad Nachman <enachman@xxxxxxxxxxx>