Re: [PATCH 2/2] dpll: zl3073x: add ZL30643 chip support

[Vincent Jardin]

Hi Ivan,

> Hi Vincent,
> I'm not sure that all driver's functionality is supported by ZL3064x. Did you test everything?
> 
> I need to check datasheets for this chip models, maybe some device flags will be needed.

I checked both datasheets. They are the same registers:

  - the register descriptions are verbatim identical

  - same chip-ID encoding (base / A +0x1000 / B +0x2000 / 7x7 +0x8000)

So ZL_CHIP_INFO(0x0E3B, 3, ZL3073X_FLAG_REF_PHASE_COMP_32) is correct
and no new device flag is needed: the ref-phase mechanism the flag
governs is identical between the families.

The only differences seem to be non-register related: line card vs
central system and the min input-frequency spec (1 kHz vs 0.5 Hz).

I tested with:

  devlink dev param set spi/spi0.0 name clock_id value 3733 cmode driverinit
  devlink dev reload spi/spi0.0

  devlink dev param set spi/spi2.1 name clock_id value 3643 cmode driverinit
  devlink dev reload spi/spi2.1

  dpll device show | grep clock-id
    clock-id: 3733
    clock-id: 3733
    clock-id: 3733
    clock-id: 3643
    clock-id: 3643
    clock-id: 3643

Best regards,
  Vincent