Re: [PATCH v5 1/4] mmc: Allow host driver to control the re-programming of Crypto keys
From: Eric Biggers
Date: Thu Jul 30 2026 - 15:15:57 EST
On Thu, Jul 30, 2026 at 07:38:19PM +0530, Neeraj Soni wrote:
> diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
> index ba84f02c2a10..83d92fb64417 100644
> --- a/include/linux/mmc/host.h
> +++ b/include/linux/mmc/host.h
> @@ -457,12 +457,9 @@ struct mmc_host {
> #define MMC_CAP2_CQE_DCMD (1 << 24) /* CQE can issue a direct command */
> #define MMC_CAP2_AVOID_3_3V (1 << 25) /* Host must negotiate down from 3.3V */
> #define MMC_CAP2_MERGE_CAPABLE (1 << 26) /* Host can merge a segment over the segment size */
> -#ifdef CONFIG_MMC_CRYPTO
> #define MMC_CAP2_CRYPTO (1 << 27) /* Host supports inline encryption */
> -#else
> -#define MMC_CAP2_CRYPTO 0
> -#endif
I'm still a bit confused why this unrelated change is included. If
you'd like to make this unrelated change, it should be a separate patch,
and the mtk-sd patch would need to be before it (not after).
- Eric