Re: [PATCH v2 2/3] iio: proximity: add driver for Sharp GP2AP070S proximity sensor

From: Uwe Kleine-König

Date: Thu Jul 30 2026 - 15:57:14 EST


Hello,

On Fri, Jul 31, 2026 at 01:01:30AM +0530, Kaustabh Chakraborty wrote:
> +#include <linux/i2c.h>
> [...]
> +#include <linux/mod_devicetable.h>

<linux/i2c.h> is enough to get the definitions for i2c_device_id and
of_device_id. Please rely on that and don't explicitly add an include
for <linux/mod_devicetable.h>. The latter is a dependency hell and is
going away soon.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature