Re: [PATCH] serial: 8250_hub6: Fix double definition for hub6_match_port()
From: Uwe Kleine-König
Date: Thu Jul 30 2026 - 15:59:13 EST
Hello Hugo,
On Thu, Jul 30, 2026 at 04:49:45PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 29, 2026 at 03:30:57PM +0200, Uwe Kleine-König wrote:
> > I think the real fix would be to just copy uart_match_port() into the
> > two drivers that actually use it (and remove the then dead code paths).
> > Then it would be drivers/tty/serial/8250/8250_core.c using
> > hub6_match_port() only and that can be handled by a proper dependency.
>
> I'm totally confused, so I'll drop this patch from my review queue and
> wait for you all to figure it out :)
Does my suggestion make sense for you? Do you intend to work on this to
unconfuse Greg?
Best regards
Uwe
Attachment:
signature.asc
Description: PGP signature