Re: [PATCH v3 1/1] pipe: only enable the extra wake_up(rd_wait) for edge-triggered consumers

From: Mateusz Guzik

Date: Thu Jul 30 2026 - 16:02:56 EST


On Thu, Jul 30, 2026 at 4:38 PM Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> What exactly do you think the comment should say? I agree with anything in
> advance. I thought that "edge-triggered" provides enough info, but I would
> be happy to improve the docs.
>

how about: There is userspace depending on the extra wake up, see
commit 3a34b13a88caeb28 ("pipe: make pipe writes always wake up
readers") for details.

or whatever else which refers to the commit, no need for anything
fancy. the current commentary is definitely lame.

> And the helper's name? pipe_enable_poll_et() ?
>

perhaps pipe_enable_epoll_semantics()?