Re: [PATCH] e1000: drop dead switch statements in configure_tx/rx

[Tony Nguyen]

On 7/29/2026 8:00 AM, Andrew Lunn wrote:
> > I see the point, but as the code is quite old and its extensive development
> > period passed long time ago, i believe value of such cosmetic patches is
> > rather questionable.
>
> It might be worth looking at the history of this code and see why it
> is this way. Sometimes odd code like this is actually a bug of some
> sort, maybe a merge conflict resolution which want wrong.

Looks like this was introduced with 24025e4ecf88 ("e1000: implementation 
of the multi-queue feature") and the multiqueue portion was removed with
c1605eb37aa6 ("e1000: Remove Multiqueue code until we have support for 
MSI-X in our hardware"). I think it was intentional but probably an 
oversight that this only left one path after the multiqueue removal.

Thanks,
Tony