Re: [PATCH] powerpc/powermac: Simplify bootx_scan_dt_build_struct()

[Christophe Leroy (CS GROUP)]

Le 21/07/2026 à 01:14, Thorsten Blum a écrit :
> Assign the empty string directly instead of NULL checking namep again.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>

Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@xxxxxxxxxx>

> ---
>   arch/powerpc/platforms/powermac/bootx_init.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powermac/bootx_init.c b/arch/powerpc/platforms/powermac/bootx_init.c
> index 72eb99aba40f..abceae91dfde 100644
> --- a/arch/powerpc/platforms/powermac/bootx_init.c
> +++ b/arch/powerpc/platforms/powermac/bootx_init.c
> @@ -284,9 +284,7 @@ static void __init bootx_scan_dt_build_struct(unsigned long base,
>   	dt_push_token(OF_DT_BEGIN_NODE, mem_end);
>   
>   	/* get the node's full name */
> -	namep = np->full_name ? (char *)(base + np->full_name) : NULL;
> -	if (namep == NULL)
> -		namep = "";
> +	namep = np->full_name ? (char *)(base + np->full_name) : "";
>   	l = strlen(namep);
>   
>   	DBG("* struct: %s\n", namep);