Re: [PATCH] powerpc/ps3: Use cpu_relax() in ps3_create_spu()
From: Christophe Leroy (CS GROUP)
Date: Fri Jul 31 2026 - 03:17:29 EST
Le 21/07/2026 à 01:11, Thorsten Blum a écrit :
Use cpu_relax() to wait for the execution status SPE_EX_STATE_EXECUTED.
Drop the comments while at it.
Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@xxxxxxxxxx>
---
arch/powerpc/platforms/ps3/spu.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/platforms/ps3/spu.c b/arch/powerpc/platforms/ps3/spu.c
index e4e0b45e1b9d..8545c72385de 100644
--- a/arch/powerpc/platforms/ps3/spu.c
+++ b/arch/powerpc/platforms/ps3/spu.c
@@ -13,6 +13,7 @@
#include <linux/export.h>
#include <linux/io.h>
#include <linux/mm.h>
+#include <linux/processor.h>
#include <asm/spu.h>
#include <asm/spu_priv1.h>
@@ -363,12 +364,9 @@ static int __init ps3_create_spu(struct spu *spu, void *data)
if (result)
goto fail_enable;
- /* Make sure the spu is in SPE_EX_STATE_EXECUTED. */
-
- /* need something better here!!! */
- while (in_be64(&spu_pdata(spu)->shadow->spe_execution_status)
- != SPE_EX_STATE_EXECUTED)
- (void)0;
+ while (in_be64(&spu_pdata(spu)->shadow->spe_execution_status) !=
+ SPE_EX_STATE_EXECUTED)
+ cpu_relax();
return result;