RE: [PATCH v2 2/2] regulator: fp9931: Fix Runtime PM usage count underflow in v3p3 ops

[Robby Cai (OSS)]

>-----Original Message-----
>From: Andreas Kemnade <andreas@xxxxxxxxxxxx>
>Sent: Sunday, July 26, 2026 3:51 AM
>To: Robby Cai (OSS) <robby.cai@xxxxxxxxxxx>
>Cc: lgirdwood@xxxxxxxxx; broonie@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
>imx@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH v2 2/2] regulator: fp9931: Fix Runtime PM usage count
>underflow in v3p3 ops
>

[...]

>> ---
>>  drivers/regulator/fp9931.c | 7 +++++--
>>  1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/regulator/fp9931.c b/drivers/regulator/fp9931.c
>> index ff743a8b0dfe..0d926546221a 100644
>> --- a/drivers/regulator/fp9931.c
>> +++ b/drivers/regulator/fp9931.c
>> @@ -214,8 +214,7 @@ static int fp9931_v3p3_enable(struct regulator_dev
>> *rdev) return ret;
>>
>>  	ret = regulator_enable_regmap(rdev);
>> -	if (ret < 0)
>> -		pm_runtime_put_autosuspend(data->dev);
>> +	pm_runtime_put_autosuspend(data->dev);
>>
>if autosuspend kicks in, the whole chip will be powered off, so if no
>vcom/vposneg is enabled, v3p3 will  also be disabled.

Thanks for the review. That makes sense. Please disregard this patch for now.

Regards,
Robby

>
>Regards,
>Andreas