Re: [PATCH v4 1/3] can: rockchip_canfd: prevent TX stall on echo skb failure

[Cunhao Lu]

Hi Marc,

Sorry for overlooking this feedback.

The previous two emails contained the same feedback as the review reply to v1, and I had already replied to that point. As a result, I mistakenly missed this message.

> I think it's better to call the can_put_echo_skb() after the
> "if (!netif_subqueue_maybe_stop())"

I agree. I will move can_put_echo_skb() to after the TX queue availability check and before any hardware TX FIFO register writes. If it fails, the driver will account the dropped frame and return without modifying the hardware FIFO or software TX state.

I will update the series accordingly in v5.

Sorry again for missing your feedback, and thank you for the review.

Best regards,
Cunhao