Re: [PATCH 0/3] fs/namei.c: comment and coding style fixups

[NeilBrown]

On Fri, 31 Jul 2026, Christian Brauner wrote:
> Neil,
> 
> Three comment and coding style fixups for your lookup_open() rework and
> Jori's audit series as they sit in vfs-7.3.lookup. No functional changes.

Thanks for doing that - looks good.  Feel free to add

Acked-by: NeilBrown <neil@xxxxxxxxxx>

if you like.

NeilBrown


> 
> * Update the comments above lookup_open(). It takes the parent inode lock
>   itself now but the comment still tells the caller to take it. A caller
>   following it deadlocks and the series added a second caller. The claim
>   that it returns 0 and updates @path goes as well, that one has been
>   wrong since v5.7.
> 
> * Give the return description of atomic_open() the colon that kernel-doc
>   needs. Without it the description is dropped and W=1 warns about it.
>   The summary line has to stand on its own line too, so the "from a
>   negative dentry" part moves into the body.
> 
> * Fix a space indented continuation line, three declarations without a
>   following blank line and a trailing */ on the last line of a block
>   comment.
> 
> Christian
> 
> ---
> Christian Brauner (3):
>       fs/namei.c: update stale comments in lookup_open()
>       fs/namei.c: fix kerneldoc of atomic_open() and vfs_lookup_open()
>       fs/namei.c: fix coding style in atomic_open() and lookup_open()
> 
>  fs/namei.c | 43 ++++++++++++++++++++++++-------------------
>  1 file changed, 24 insertions(+), 19 deletions(-)
> ---
> base-commit: b2f1e6301efa4a80becdb0715416c3cbc693fbb4
> change-id: 20260731-work-lookup-fixes-73bd87cc2d24
> 
>