Re: [PATCH 3/3] staging: rtl8723bs: convert dump mgnt path to errno

[Dan Carpenter]

On Fri, Jul 31, 2026 at 07:05:46AM +0000, Hungyu Lin wrote:
> Convert dump_mgntframe_and_wait() to return errno-style values and
> update its declaration in rtw_mlme_ext.h.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@xxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c    | 13 ++++---------
>  drivers/staging/rtl8723bs/include/rtw_mlme_ext.h |  2 +-
>  2 files changed, 5 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index 0027f9333738..da74184fd07e 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -1971,9 +1971,9 @@ void dump_mgntframe(struct adapter *padapter, struct xmit_frame *pmgntframe)
>  	rtw_hal_mgnt_xmit(padapter, pmgntframe);
>  }
>  
> -s32 dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *pmgntframe, int timeout_ms)
> +int dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *pmgntframe, int timeout_ms)

This is like patch 1 where nothing checks for errors.  I feel like
the right thing here is to change it to a void function.  (Based on
the "dump" in the name and not based on careful reading).

Either way it probably should have an explanation in the commit
message.

regards,
dan carpenter