Re: [PATCH 1/3] staging: rtl8723bs: convert mgmt xmit coalesce to errno

[Dan Carpenter]

On Fri, Jul 31, 2026 at 07:05:44AM +0000, Hungyu Lin wrote:
> Change rtw_mgmt_xmitframe_coalesce() to use kernel-style return values.
> Return 0 on success and negative errno on failure, and update the
> declaration in rtw_xmit.h accordingly
> 
> Signed-off-by: Hungyu Lin <dennylin0707@xxxxxxxxx>

Ideally the commit message would explain that "This is safe because
the only caller doesn't check for errors".  But then the question
is "why don't we just make this a void function?" and the answer
is that this shouldn't be a void function, the caller really ought
to check for errors.

  Change rtw_mgmt_xmitframe_coalesce() to use kernel-style return values.
  Return 0 on success and negative errno on failure.  The caller doesn't
  check for errors so this doesn't affect runtime.  Later patches will
  hopefully add error checking.

regards,
dan carpenter