Re: [PATCH v3 2/7] char: xillybus: Remove duplicate error path code

[Greg KH]

On Fri, Jul 24, 2026 at 11:42:57AM +0200, Eli Billauer wrote:
> No need for dedicated code for the error path. The removed dedicated
> error path code differs only in when the mutex is released, and that
> makes no difference in this context.
> 
> Assisted-by: Deepseek:v4-pro Kimi:K2.6 ChatGPT:GPT-5.5 Claude:Sonnet-4.6
> Signed-off-by: Eli Billauer <eli.billauer@xxxxxxxxx>
> ---
> 
> Notes:
>     Changes v2->v3:
>      -- Add Assisted-by tag to description
>     
>     No change on v1->v2.
> 
>  drivers/char/xillybus/xillyusb.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/char/xillybus/xillyusb.c b/drivers/char/xillybus/xillyusb.c
> index a28e6416cb01..ab5f9159aa17 100644
> --- a/drivers/char/xillybus/xillyusb.c
> +++ b/drivers/char/xillybus/xillyusb.c
> @@ -1419,16 +1419,12 @@ static int xillyusb_open(struct inode *inode, struct file *filp)
>  	if (filp->f_mode & FMODE_WRITE)
>  		chan->open_for_write = 0;
>  
> +unmutex_fail:
>  	mutex_unlock(&chan->lock);
>  
>  	kref_put(&xdev->kref, cleanup_dev);
>  
>  	return rc;
> -
> -unmutex_fail:
> -	kref_put(&xdev->kref, cleanup_dev);
> -	mutex_unlock(&chan->lock);
> -	return rc;
>  }
>  
>  static ssize_t xillyusb_read(struct file *filp, char __user *userbuf,
> -- 
> 2.34.1
> 

Again, some sashiko comments seem like this might not be the correct
changelog text:

	https://sashiko.dev/#/patchset/20260724094302.50761-1-eli.billauer@xxxxxxxxx

Can you verify that the other comments in that review for this series
isn't also valid (or not?)

thanks,

greg k-h