Re: [PATCH v2 4/4] serial: imx: serialize imx_uart_ports[] lifetime
From: Karl Mehltretter
Date: Fri Jul 31 2026 - 10:01:29 EST
On Thu, Jul 30, 2026 at 04:31:51PM +0100, Greg Kroah-Hartman wrote:
> >
> > + mutex_lock(&imx_uart_ports_lock);
>
> guard()?
>
I'll use guards for v3.
> > + unsigned int line = sport->port.line;
>
> Why are you reading this outside of the lock?
>
Good question. The local variable is unnecessary. I'll remove it.
Thanks,
Karl