Re: [PATCH v5 02/14] mfd: lm3533: Remove driver specific regmap wrappers

[Johan Hovold]

On Tue, Jul 14, 2026 at 04:26:49PM +0300, Svyatoslav Ryhel wrote:
> пт, 3 лип. 2026 р. о 12:44 Johan Hovold <johan@xxxxxxxxxx> пише:
> >
> > On Wed, Jun 17, 2026 at 11:00:19AM +0300, Svyatoslav Ryhel wrote:
> > > Remove driver-specific regmap wrappers in favor of using regmap helpers
> > > directly.
> >
> > The commit message should explain why you think this is a good idea.
> >
> 
> Removing custom wrappers over standard regmap helpers is always a good
> idea, that is self explanatory.

No, and especially not if you're removing functionality.

> > Based on a quick look you lose the errnos that were logged on errors and
> > also the register debugging provided by those helpers.
> >
> 
> That is not true, regmap helpers will provide logging and you should
> not include debug stuff into the final submitted driver unless you
> have a extremely valid justification for this, debug logs should have
> been removed once the driver development was completed.

The regmap logging is a compile-time thing (added after the driver was
merged), and not equivalent to what the driver provides currently.

The driver also currently relies on these helpers for logging errnos.

Johan