Re: [PATCH 04/11] usb: dwc3: Remove redundant dev_err()/dev_err_probe()

[Frank Li]

On Fri, Jul 31, 2026 at 11:54:38AM +0800, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"),
> devm_request_irq() and devm_request_threaded_irq() automatically log
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() and dev_err_probe() calls.
>
> Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
> ---
>  drivers/usb/dwc3/dwc3-google.c   | 4 +---
>  drivers/usb/dwc3/dwc3-imx.c      | 2 +-
>  drivers/usb/dwc3/dwc3-imx8mp.c   | 4 +---

for imx part

Acked-by: Frank Li <Frank.Li@xxxxxxx>

>  drivers/usb/dwc3/dwc3-keystone.c | 5 +----
>  drivers/usb/dwc3/dwc3-omap.c     | 5 +----
>  5 files changed, 5 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-google.c b/drivers/usb/dwc3/dwc3-google.c
> index 60ee4cc99b28..e581d407b872 100644
> --- a/drivers/usb/dwc3/dwc3-google.c
> +++ b/drivers/usb/dwc3/dwc3-google.c
> @@ -235,10 +235,8 @@ static int dwc3_google_request_irq(struct dwc3_google *google, struct platform_d
>  					dwc3_google_resume_irq,
>  					IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
>  					req_name, google);
> -	if (ret < 0) {
> -		dev_err(google->dev, "failed to request irq %s\n", req_name);
> +	if (ret < 0)
>  		return ret;
> -	}
>
>  	return irq;
>  }
> diff --git a/drivers/usb/dwc3/dwc3-imx.c b/drivers/usb/dwc3/dwc3-imx.c
> index 973a486b544d..d967acd43d44 100644
> --- a/drivers/usb/dwc3/dwc3-imx.c
> +++ b/drivers/usb/dwc3/dwc3-imx.c
> @@ -250,7 +250,7 @@ static int dwc3_imx_probe(struct platform_device *pdev)
>  					IRQF_ONESHOT | IRQF_NO_AUTOEN,
>  					irq_name, dwc_imx);
>  	if (ret)
> -		return dev_err_probe(dev, ret, "failed to request IRQ #%d\n", irq);
> +		return ret;
>
>  	ret = device_add_software_node(dev, &dwc3_imx_swnode);
>  	if (ret)
> diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c
> index 1cf96540b66e..ee92a5efaa6e 100644
> --- a/drivers/usb/dwc3/dwc3-imx8mp.c
> +++ b/drivers/usb/dwc3/dwc3-imx8mp.c
> @@ -273,10 +273,8 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
>
>  	err = devm_request_threaded_irq(dev, irq, NULL, dwc3_imx8mp_interrupt,
>  					IRQF_ONESHOT, dev_name(dev), dwc3_imx);
> -	if (err) {
> -		dev_err(dev, "failed to request IRQ #%d --> %d\n", irq, err);
> +	if (err)
>  		goto put_dwc3;
> -	}
>
>  	device_set_wakeup_capable(dev, true);
>  	pm_runtime_put(dev);
> diff --git a/drivers/usb/dwc3/dwc3-keystone.c b/drivers/usb/dwc3/dwc3-keystone.c
> index 7ee1610162b9..8ad302abe883 100644
> --- a/drivers/usb/dwc3/dwc3-keystone.c
> +++ b/drivers/usb/dwc3/dwc3-keystone.c
> @@ -144,11 +144,8 @@ static int kdwc3_probe(struct platform_device *pdev)
>
>  	error = devm_request_irq(dev, irq, dwc3_keystone_interrupt, IRQF_SHARED,
>  			dev_name(dev), kdwc);
> -	if (error) {
> -		dev_err(dev, "failed to request IRQ #%d --> %d\n",
> -				irq, error);
> +	if (error)
>  		goto err_irq;
> -	}
>
>  	kdwc3_enable_irqs(kdwc);
>
> diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
> index fe74d11bb629..3bff775fbe4e 100644
> --- a/drivers/usb/dwc3/dwc3-omap.c
> +++ b/drivers/usb/dwc3/dwc3-omap.c
> @@ -518,11 +518,8 @@ static int dwc3_omap_probe(struct platform_device *pdev)
>  	ret = devm_request_threaded_irq(dev, omap->irq, dwc3_omap_interrupt,
>  					dwc3_omap_interrupt_thread, IRQF_SHARED,
>  					"dwc3-omap", omap);
> -	if (ret) {
> -		dev_err(dev, "failed to request IRQ #%d --> %d\n",
> -			omap->irq, ret);
> +	if (ret)
>  		goto err2;
> -	}
>  	dwc3_omap_enable_irqs(omap);
>  	return 0;
>
> --
> 2.34.1
>
>