Re: [PATCH 0/2] watchdog: pretimeout: Allow building dump governor as module

[Guenter Roeck]

On 7/31/26 14:01, Andrew Morton wrote:
> On Thu, 30 Jul 2026 16:39:14 -0700 Mayank Rungta <mrungta@xxxxxxxxxx> wrote:
>
> > On Thu, Jul 30, 2026 at 3:50 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > > On Thu, 30 Jul 2026 15:00:20 -0700 Mayank Rungta via B4 Relay <devnull+mrungta.google.com@xxxxxxxxxx> wrote:
> > >
> > > > All other watchdog pretimeout governors (noop, panic) can be built as
> > > > loadable modules. However the "dump" pretimeout governor is restricted
> > > > to built-in code because it calls trigger_all_cpu_backtrace(), which
> > > > relies on arch_trigger_cpumask_backtrace(), an arch specific helper that
> > > > is not exported to loadable modules.
> > > >
> > > > This 2-patch series allows building the dump governor as a module (=m):
> > > > 1) Export cpumask_backtrace() in lib/nmi_backtrace.c.
> > > > 2) Convert CONFIG_WATCHDOG_PRETIMEOUT_GOV_DUMP from bool to tristate.
> > >
> > > LGTM.  Can you please redo against current mainline?  The Kconfig has
> > > changed.
> >
> > Thanks for the LGTM!
> >
> > Regarding rebasing onto mainline (origin/master): The "dump"
> > pretimeout governor was added recently by Tzung-Bi Shih ("watchdog:
> > pretimeout: Add "dump" pretimeout governor") and is currently in
> > linux-next, so it hasn't landed in mainline tree yet.
> >
> > Because of this dependency, I based this series on linux-next so that
> > patch 2/2 ("Convert dump pretimeout governor to tristate") could apply
> > cleanly on top of the new governor.
> >
> > Please let me know what is preferred, or if you'd like me to post
> > against a different tree!
>
> Oh, OK.
>
> Guenter, can you please process this patchset?

Sure. Assuming you'd like me to handle it through the watchdog branch,
it would be great if you can send a formal Acked-by: to the first patch
of the series.

Thanks,
Guenter