Re: [PATCH] kbuild: fix modules.builtin(.modinfo) targets in the top-level Makefile

[Nathan Chancellor]

> Commit 7a342e6c7735 ("kbuild: move modules.builtin(.modinfo) rules to
> Makefile.vmlinux_o") moved the modules.builtin(.modinfo) rules from
> link-vmlinux.sh to Makefile.vmlinux_o, and added the corresponding
> targets to the top-level Makefile.
> 
> Commit 39cfd5b12160 ("kbuild: extract modules.builtin.modinfo from
> vmlinux.unstripped") later moved these rules from Makefile.vmlinux_o to
> Makefile.vmlinux, but left the corresponding targets in the top-level
> Makefile unchanged.
> 
> These modules.builtin(.modinfo) targets in the top-level Makefile should
> be moved alongside the vmlinux target, since they are now generated by
> Makefile.vmlinux.
> 
> However, simply removing these trivial targets might be a better choice,
> as it makes the Makefile cleaner and avoids the need to keep them in sync
> across multiple files, reducing the chance of future mistakes.
> 
> Fixes: 39cfd5b12160 ("kbuild: extract modules.builtin.modinfo from vmlinux.unstripped")
> Signed-off-by: Yuntao Wang <yuntao.wang@xxxxxxxxx>

Well I suppose if nobody has reported these targets being broken, it
probably means nobody is using them. It is easy enough to put them back
if somebody needs/wants them.

Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx>

-- 
Cheers,
Nathan