Re: [PATCH net-next v7] net: phy: Add driver for Motorcomm Quad 2.5GbE phy
From: Kyle Switch
Date: Fri Jul 31 2026 - 23:52:54 EST
On 7/31/26 06:35, Jakub Kicinski wrote:
> On Tue, 28 Jul 2026 19:21:05 +0800 Kyle Switch wrote:
>> Add a driver for motorcomm yt8824 quad 2.5G ethernet phy, supports
>> 2.5G/1000M/100M/10M speed
>
> Missing some kdoc returns:
>
> Warning: drivers/net/phy/phy-c45.c:1293 No description found for return value of 'genphy_c45_template_testmode'
> Warning: drivers/net/phy/phy-c45.c:1293 No description found for return value of 'genphy_c45_template_testmode'
>
> Plus at a glance you also added stray semicolons after functions?
>
> Last but not least, Sashiko/Gemini has 10 complaints, please check
> these before working on v8:
>
> https://sashiko.dev/#/patchset/20260728112105.2668014-1-kyle.switch@xxxxxxxxxxxxxx
Ans: fix done in v8. add missing kdoc returns descriptions and fix the complaints. Thank you.