Re: [PATCH] wifi: rsi: Fix types to appease CFI

[Stefan Hansson]

Hello Johannes,

On 02/08/2026 18:24, Johannes Berg wrote:
> On Sun, 2026-08-02 at 14:22 +0200, Stefan Hansson wrote:
> > Avoids errors like:
> >
> >      CFI failure at kthread+0x124/0x1cc (target: rsi_coex_scheduler_thread+0x0/0x1b4 [redpine_91x]; expected type: 0x89fb613d)
>
> Yeah, well. Everyone gets _one_ warning to send patches that actually
> build warning-free, after that I just drop them without notice...

Could you clarify what you are referring to here? I don't get any errors 
when building after applying this patch on top of next-20260730:

$ make -j4
make: Entering directory '/mnt/linux'
make[1]: Entering directory '/mnt/linux/.output'
  CC [M]  drivers/net/wireless/rsi/rsi_91x_main.o
  CC [M]  drivers/net/wireless/rsi/rsi_91x_core.o
  CC [M]  drivers/net/wireless/rsi/rsi_91x_mac80211.o
  CC [M]  drivers/net/wireless/rsi/rsi_91x_mgmt.o
  CC [M]  drivers/net/wireless/rsi/rsi_91x_hal.o
  CC [M]  drivers/net/wireless/rsi/rsi_91x_ps.o
  CC [M]  drivers/net/wireless/rsi/rsi_91x_coex.o
  CC [M]  drivers/net/wireless/rsi/rsi_91x_debugfs.o
  CC [M]  drivers/net/wireless/rsi/rsi_91x_sdio.o
  CC [M]  drivers/net/wireless/rsi/rsi_91x_sdio_ops.o
  CC [M]  drivers/net/wireless/rsi/rsi_91x_usb.o
  CC [M]  drivers/net/wireless/rsi/rsi_91x_usb_ops.o
  LD [M]  drivers/net/wireless/rsi/rsi_91x.o
  LD [M]  drivers/net/wireless/rsi/rsi_sdio.o
  LD [M]  drivers/net/wireless/rsi/rsi_usb.o
  MODPOST Module.symvers
  CC [M]  drivers/net/wireless/rsi/rsi_91x.mod.o
  CC [M]  drivers/net/wireless/rsi/rsi_sdio.mod.o
  CC [M]  drivers/net/wireless/rsi/rsi_usb.mod.o
  LD [M]  drivers/net/wireless/rsi/rsi_usb.ko
  LD [M]  drivers/net/wireless/rsi/rsi_sdio.ko
  LD [M]  drivers/net/wireless/rsi/rsi_91x.ko
make[1]: Leaving directory '/mnt/linux/.output'
make: Leaving directory '/mnt/linux'

FWIW I am building using Clang/LLVM.

If you are referring to checkpatch.pl complaining about the 
aforementioned error line being too long, I can wrap it if you prefer that.

> johannes

Stefan Hansson