Re: [PATCH] Bluetooth: btusb: clear remote wake on idle Intel ACPI paths
From: Paul Menzel
Date: Tue Aug 04 2026 - 07:10:38 EST
Dear Sean,
Thank you for your patch.
Am 04.08.26 um 12:13 schrieb Sean Rhodes:
Commit 6953217d9f44 ("usb: core: allow ACPI-managed hard-wired
I am unable to find this commit in Linus’ master or bluetooth-next [1].
ports to power off") allows internal USB devices on ACPI-managed
hard-wired ports to use the existing runtime power-off path. For Intel
combined USB Bluetooth controllers, btusb still keeps runtime remote wake
enabled for as long as the adapter is open, which prevents the USB PM
core from dropping the last child reference and powering the port off
while idle.
Only keep runtime remote wake enabled while the controller is expected to
signal activity on its own: initialization, outstanding HCI commands,
established links, discovery, LE scan, LE advertising, BR/EDR page or
inquiry scan, diagnostic modes, DUT mode, quality reports, or Intel
devcoredump collection. When those are idle, clear needs_remote_wakeup so
autosuspend can power-manage the port and a later host-initiated command
can resume the device again.
Please add a paragraph how you tested this, and how others can test this.
As the diffstat is over 900 lines of code, could you add a paragraph giving an implementation overview?
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Add a Fixes: tag?
---
drivers/bluetooth/btusb.c | 917 +++++++++++++++++++++++++++++-
include/net/bluetooth/bluetooth.h | 1 +
include/net/bluetooth/hci.h | 4 +
net/bluetooth/hci_debugfs.c | 20 +-
net/bluetooth/hci_sock.c | 5 +
net/bluetooth/hci_sync.c | 2 +
net/bluetooth/mgmt.c | 15 +-
7 files changed, 940 insertions(+), 24 deletions(-)
[…]
Note, that gemini/gemini-3.1-pro-preview commented on some things [1].
Kind regards,
Paul
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=6953217d9f44
[2]: https://sashiko.dev/#/patchset/48576c0c4615c9f34f44935216e63d48518f9d46.1785838429.git.sean%40starlabs.systems