Re: [PATCH v3 2/2] clk: qcom: Add LPASS VA CSR heartbeat pulse clock
From: Sarath Ganapathiraju
Date: Tue Aug 04 2026 - 07:21:00 EST
On Tue, Jul 28, 2026 at 02:12:07PM +0200, Konrad Dybcio wrote:
> This patch spans 2 subsystems and 2 separate maintainers.. we'll need
> Mark's ack for the sound/ change
Ack, will cc Mark and get his approval on next version.
> VA_CSR is the Control-and-Status-Register space of the VA Macro,
> the name of the config should definitely focus on the heartbeat
> pulse clock generator within it instead
Ack. Will rename in the next revision.
> Besides, that address space is huge, yet you're claiming it for
> a single simple clock. Exposing anything else from within there
> in the future will require bindings updates, which are usually a
> tough sell. Is there anything else in there that we need to cover
> from HLOS?
The only register block we need from HLOS is the rate generator at
offsets 0xd000-0xd010 (CTRL, COUNTER_0, DELAY). Nothing else in the
VA CSR space needs HLOS coverage for hawi. Will narrow the reg to
cover only those registers in the next revision.
Thanks,
Sarath