Re: [PATCH v3] staging: rtl8723bs: remove redundant ternary operators from return

[Greg KH]

On Tue, Aug 04, 2026 at 11:14:43AM +0000, Ashmit Kumar wrote:
> The Linux kernel coding style specifies that boolean expressions
> do not need a redundant `? true : false` ternary operator.
> Additionally, return is not a function and therefore parentheses
> are not required.
> 
> Signed-off-by: Ashmit Kumar <work.ashmitkumar@xxxxxxxxx>
> ---
> Changes in v3:
> - Formatted as a standalone patch (removed 1/3 series numbering).
> 
>  drivers/staging/rtl8723bs/os_dep/osdep_service.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> index 4cfdf7c6234..214c1fd9b3e 100644
> --- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> +++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> @@ -130,7 +130,7 @@ void rtw_buf_update(u8 **buf, u32 *buf_len, u8 *src, u32 src_len)
>   */
>  inline bool rtw_cbuf_full(struct rtw_cbuf *cbuf)
>  {
> -	return (cbuf->write == cbuf->read - 1) ? true : false;
> +	return cbuf->write == cbuf->read - 1;
>  }

This is only used in one place, right?  Why not convert it to use a
proper ring buffer instead?

>  /**
> @@ -141,7 +141,7 @@ inline bool rtw_cbuf_full(struct rtw_cbuf *cbuf)
>   */
>  inline bool rtw_cbuf_empty(struct rtw_cbuf *cbuf)
>  {
> -	return (cbuf->write == cbuf->read) ? true : false;
> +	return cbuf->write == cbuf->read;
>  }

Same here, only used once, why not use the proper data structure?

and same comments as on other one, slow down, full version info, etc.

thanks,

greg k-h