Re: [PATCH v4] x86/virt/tdx: Formalize SEAMCALL version encoding support

From: Dave Hansen

Date: Tue Aug 04 2026 - 13:09:43 EST


On 8/4/26 01:50, Xu Yilun wrote:
> SEAMCALL invokes TDX module functions using a function number and

Maybe I'm just grumpy this morning, but I'm not a fan of this
description. It seems to just be growing complexity and not actually
explaining the situation better.

Also, this is going to be subtle but it starts talking (I think) about
the SEAMCALL _instruction_. The thing this patch should be talking about
is SEAMCALLs themselves. The instruction is a _part_ that, sure. But the
instruction itself actually has very little to do with the ABI.

I just feel like the whole explanation here is going off in a different
direction than we need.