Re: [PATCH v7 1/7] ASoC: qcom: qdsp6: add topology-driven Audio IF support

[Cezary Rojewski]

On 8/4/2026 9:03 AM, Prasad Kumpatla wrote:
> Add topology parsing and media-format programming for Audio IF source and
> sink modules.

...

>   include/uapi/sound/snd_ar_tokens.h |  93 ++++++++++++++++++++++++++

Meh, looks like QCOM took a "bad" example from Intel's past drivers and 
put the header directly within uapi/sound/ without any meaningful 
prefix. Even moving the header into vendor-specific subfolder e.g.: 
uapi/sound/qcom/ would be a good start. For "better" examples take a 
look at headers exposed for newer drivers: sound/intel and sound/sof.

I'd suggest to move away from snd_ar_tokens.h (the name is as ambiguous 
is at can be) and start new header family within 'qcom' subfolder.

At the same time I'll prepare a patch and remove the remaining "bad" 
examples so people don't propagate them.


Kind regards,
Czarek