Re: [PATCH 01/13] PCI/P2PDMA: Safely terminate ACS redirect lists

[Logan Gunthorpe]

On 2026-08-02 09:09, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxx>
> 
> seq_buf marks an overflow by setting len to size + 1. The ACS diagnostic
> path unconditionally writes a terminator to buffer[len - 1], so a path
> with enough ACS ports to fill the 128-byte buffer writes one byte beyond
> the buffer when verbose diagnostics are requested.
> 
> Use seq_buf_str() to terminate truncated output safely and remove the final
> semicolon only when the buffer did not overflow.
> 
> Fixes: 52916982af48 ("PCI/P2PDMA: Support peer-to-peer memory")
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>

Looks good to me, thanks!

Reviewed-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>