Re: [PATCH] iio: humidity: am2315: add am2320 to i2c_device_id table

[Nuno Sá]

On Wed, Aug 05, 2026 at 03:37:26PM -0300, Nicolás Antinori wrote:
> The AM2320 is fully compatible with the AM2315 sensor in terms of I2C
> communication protocol and measurement conversions.
> 
> Add the "am2320" entry to the i2c_device_id table.
> 
> Signed-off-by: Nicolás Antinori <nico.antinori.7@xxxxxxxxx>
> ---

One minor comment from me (maybe Jonathan can tweak it while applying).
With that:

Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>

> Tested with Raspberry Pi 3b+
> 
> Used as reference AM2315 Datasheet [1] and AM2320 datasheet [2]
> 
> [1] https://cdn-shop.adafruit.com/datasheets/AM2315.pdf
> [2] https://cdn-shop.adafruit.com/product-files/3721/AM2320.pdf
> 
>  drivers/iio/humidity/Kconfig  | 4 ++--
>  drivers/iio/humidity/am2315.c | 3 ++-
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
> index 54f11f000b6f..6907805945f3 100644
> --- a/drivers/iio/humidity/Kconfig
> +++ b/drivers/iio/humidity/Kconfig
> @@ -5,13 +5,13 @@
>  menu "Humidity sensors"
> 
>  config AM2315
> -	tristate "Aosong AM2315 relative humidity and temperature sensor"
> +	tristate "Aosong AM2315/AM2320 relative humidity and temperature sensor"
>  	depends on I2C
>  	select IIO_BUFFER
>  	select IIO_TRIGGERED_BUFFER
>  	help
>  	  If you say yes here you get support for the Aosong AM2315
> -	  relative humidity and ambient temperature sensor.
> +	  and AM2320 relative humidity and ambient temperature sensors.

The above (same on the tristate title) does not really scale nicely and
we've seen too often already. So I use something like "... and similar
devices"

- Nuno Sá

> 
>  	  This driver can also be built as a module. If so, the module will
>  	  be called am2315.
> diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.c
> index f29baa251f9f..5bce5eec45cc 100644
> --- a/drivers/iio/humidity/am2315.c
> +++ b/drivers/iio/humidity/am2315.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0-only
>  /*
> - * Aosong AM2315 relative humidity and temperature
> + * Aosong AM2315/AM2320 relative humidity and temperature
>   *
>   * Copyright (c) 2016, Intel Corporation.
>   *
> @@ -251,6 +251,7 @@ static int am2315_probe(struct i2c_client *client)
> 
>  static const struct i2c_device_id am2315_i2c_id[] = {
>  	{ .name = "am2315" },
> +	{ .name = "am2320" },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, am2315_i2c_id);
> --
> 2.47.3
>