Re: [PATCH net] bonding: fix wrong extack attribute in ARP validate netlink error path

[Fernando Fernandez Mancera]

On 8/6/26 5:29 AM, Hangbin Liu wrote:
> From: Hangbin Liu <liuhangbin@xxxxxxxxxx>
>
> The attribute of netlink error message should be IFLA_BOND_ARP_VALIDATE
> when ARP validation setting fails.
>
> Fixes: 2bff369b2354 ("bonding: netlink error message support for options")
> Signed-off-by: Hangbin Liu <liuhangbin@xxxxxxxxxx>
> ---

Reviewed-by: Fernando Fernandez Mancera <fmancera@xxxxxxx>

Thanks!

>   drivers/net/bonding/bond_netlink.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c
> index 4a11572f663d..7dc31b2551c4 100644
> --- a/drivers/net/bonding/bond_netlink.c
> +++ b/drivers/net/bonding/bond_netlink.c
> @@ -372,7 +372,7 @@ static int bond_changelink(struct net_device *bond_dev, struct nlattr *tb[],
>   		int arp_validate = nla_get_u32(data[IFLA_BOND_ARP_VALIDATE]);
>   
>   		if (arp_validate && miimon) {
> -			NL_SET_ERR_MSG_ATTR(extack, data[IFLA_BOND_ARP_INTERVAL],
> +			NL_SET_ERR_MSG_ATTR(extack, data[IFLA_BOND_ARP_VALIDATE],
>   					    "ARP validating cannot be used with MII monitoring");
>   			return -EINVAL;
>   		}
>
> ---
> base-commit: 2a33516f9ef59ad11844d4fc152f889449b5daf3
> change-id: 20260806-bond_arp_validate-359289656609
>
> Best regards,