Re: [PATCH net-next v1 2/2] net: dsa: realtek: rtl83xx: add support for enabling supplies

[Linus Walleij]

On Thu, Aug 6, 2026 at 5:56 PM Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> wrote:

[Andrew says]
> > static inline int __must_check clk_bulk_get_optional(struct device *dev,
> > static inline int __must_check devm_clk_bulk_get_optional(struct device *dev,
> > static inline int __must_check devm_clk_bulk_get_optional_enable(struct device *dev,
> >
> > If clk has them, maybe regulators should as well?
>
> clk and regulator have different interpretations of _optional
> when encountering a non-existent resource:
>
> clk_get                 return error
> clk_get_optional        return NULL
> regulator_get           return handle dummy regulator
> regulator_get_optional  return error code
>
> So devm_regulator_bulk_get() is already the "optional" variant, but it causes
> all existing users to get dummy supply warnings.

So is this a big problem? Does it cause any other issues than
dmesg noise?

Yours,
Linus Walleij