Re: [PATCH 2/2] watchdog: pretimeout: Convert dump pretimeout governor to tristate

[Guenter Roeck]

On Thu, Jul 30, 2026 at 03:00:22PM -0700, Mayank Rungta wrote:
> From: Mayank Rungta <mrungta@xxxxxxxxxx>
> 
> Commit 645ad41da8b2 ("watchdog: pretimeout: Add "dump" pretimeout
> governor") added the "dump" watchdog pretimeout governor, but restricted
> it to built-in code because trigger_all_cpu_backtrace() was not exported
> to loadable modules.
> 
> Now that CPU backtrace APIs are supported for loadable kernel modules
> via cpumask_backtrace(), convert WATCHDOG_PRETIMEOUT_GOV_DUMP to
> tristate. This allows kernels to deliver the pretimeout governor as a
> loadable kernel module.
> 
> Signed-off-by: Mayank Rungta <mrungta@xxxxxxxxxx>
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>

As mentioned in the other patch, I can not apply the series without Ack
from a maintainer. In case someone else wants to pick it up instead:

Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>  drivers/watchdog/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 9f013d774897..922741dd837c 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -99,8 +99,8 @@ config WATCHDOG_PRETIMEOUT_GOV_SEL
>  if WATCHDOG_PRETIMEOUT_GOV
>  
>  config WATCHDOG_PRETIMEOUT_GOV_DUMP
> -	bool "Dump watchdog pretimeout governor"
> -	depends on WATCHDOG_CORE=y
> +	tristate "Dump watchdog pretimeout governor"
> +	depends on WATCHDOG_CORE
>  	default WATCHDOG_CORE
>  	help
>  	  Dump watchdog pretimeout governor, all cpu backtrace is