Re: [syzbot] [mm?] WARNING in mas_nomem

[Liam R. Howlett]

On 26/08/06 12:48PM, Jason Gunthorpe wrote:
> On Thu, Aug 06, 2026 at 10:29:27AM -0400, Liam R. Howlett wrote:
> 
> > @@ -5609,8 +5612,7 @@ void *mas_store(struct ma_state *mas, void *entry)
> >  		goto store;
> >  
> >  	mas_alloc_nodes(mas, GFP_NOWAIT);
> > -	if (mas_is_err(mas))
> > -		return NULL;
> > +	mas_nomem(mas, GFP_KERNEL | __GFP_NOFAIL);
> 
> It still feels really weird to ignore the return code from mas_nomem..
> 
>  void mas_nomem_nofail() 

Sure, that's fair.

> 
> ? and maybe it can have a WARN_ON


The warning would never trigger.  If the allocation fails with nofail,
then you'd never reach the warning.

Thanks,
Liam