Re: [PATCH v2] iio: accel: mma8452: add ACPI match table
From: Andy Shevchenko
Date: Sat Aug 08 2026 - 16:33:54 EST
On Fri, Aug 07, 2026 at 08:13:25PM +0300, Danil Sirin wrote:
> The mma8452 driver supports obtaining chip-specific data through
> i2c_get_match_data(), but only provides Device Tree and I2C match
> tables.
>
> On ACPI-based x86 systems, compatible devices such as the MMA8653 are
> enumerated via ACPI, preventing the driver from binding.
>
> Add an ACPI match table mapping the supported devices to the existing
> chip information structures.
>
> Tested on a Bay Trail tablet exposing an MMA8653 device via ACPI. With
> this change the driver successfully probes, reads the expected chip ID
> (0x5a), and registers an IIO device.
...
Jonathan beat me up to it, so follow exactly what he said, we do not accept
fake ACPI IDs, they must be properly registered. Yet, for the broken ones in
the wild (device is on market), we need to have a shameful comment and a note
to the vendor of the firmware (BIOS) to explain them that they are wrong.
Also check the MS catalog for the ID if it appears in the Windows drivers.
This information also has to be added to the commit message.
--
With Best Regards,
Andy Shevchenko