Re: [PATCH v2 2/6] phy: qcom: sgmii-eth: vote for both voltage rails with correct current loads

[Bartosz Golaszewski]

On Mon, 3 Aug 2026 21:27:58 +0200, Mohd Ayaan Anwar
<mohd.anwar@xxxxxxxxxxxxxxxx> said:
> The SerDes PHY has two voltage supply rails, vdda-0p9 and vdda-1p2,
> that must both be enabled for calibration to succeed. Without them:
>
>   qcom-dwmac-sgmii-phy 8909000.phy: QSERDES_COM_C_READY_STATUS timed-out
>   qcom-ethqos 23040000.ethernet eth0: __stmmac_open: Serdes powerup failed
>
> The driver relied solely on the PHY framework's implicit enable of
> 'phy-supply', which only voted for a single rail and set no current
> load. Use devm_regulator_bulk_get_const() to acquire both supplies and
> set the peak current loads (46 mA for vdda-0p9, 15 mA for vdda-1p2)
> as required by the hardware.
>
> Fixes: 601d06277007 ("phy: qcom: add the SGMII SerDes PHY driver")
> Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@xxxxxxxxxxxxxxxx>
> ---

Thanks for doing this Mohd!

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>