Re: [PATCH 2/6] mm: remove PageReclaim

From: Lorenzo Stoakes (ARM)

Date: Mon Aug 10 2026 - 09:00:48 EST


On Mon, Aug 10, 2026 at 01:38:21PM +0200, David Hildenbrand (Arm) wrote:
> On 8/7/26 21:27, Tal Zussman wrote:
> > On 8/7/26 2:48 PM, Matthew Wilcox wrote:
> >> On Thu, Aug 06, 2026 at 06:55:34PM -0400, Tal Zussman wrote:
> >>> This flag is now only used on folios, so we can remove all the page
> >>> accessors.
> >>
> >> And we don't use folio_test_clear_reclaim() at all (it's mentioned in
> >> a comment, but that's it), so we can drop that line entirely.
> >>
> >
> > Aha, I missed that - even better.
> >
> >>> -PAGEFLAG(Reclaim, reclaim, PF_NO_TAIL)
> >>> - TESTCLEARFLAG(Reclaim, reclaim, PF_NO_TAIL)
> >>> +FOLIO_FLAG(reclaim, FOLIO_HEAD_PAGE)
> >>> + FOLIO_TEST_CLEAR_FLAG(reclaim, FOLIO_HEAD_PAGE)
> >>
> >> With that last line removed,
> >>
> >> Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
>
> Thanks
>
> Acked-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>

Nice! With Matthew's suggestion applied LGTM so:

Reviewed-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>

>
> --
> Cheers,
>
> David

--
Cheers, Lorenzo