Re: [PATCH] selftests/futex: Correct pthread_create return value check

[Thomas Gleixner]

On Mon, Jul 27 2026 at 11:08, Lei Zhu wrote:
> From: Lei Zhu <zhulei@xxxxxxxxxx>
>
> The pthread_create() functions returns 0 on success and a positive value on
> failure. Modify the return value check to correctly detect failure cases.
>
> Fixes: 14d016bd7282 ("selftests/futex: Refactor futex_wait_private_mapped_file with kselftest_harness.h")
> Signed-off-by: Lei Zhu <zhulei@xxxxxxxxxx>
> ---
>  .../selftests/futex/functional/futex_wait_private_mapped_file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/futex/functional/futex_wait_private_mapped_file.c b/tools/testing/selftests/futex/functional/futex_wait_private_mapped_file.c
> index 2a749f9b14eb..e6266c8a357e 100644
> --- a/tools/testing/selftests/futex/functional/futex_wait_private_mapped_file.c
> +++ b/tools/testing/selftests/futex/functional/futex_wait_private_mapped_file.c
> @@ -62,7 +62,7 @@ TEST(wait_private_mapped_file)
>  	int res;
>  
>  	res = pthread_create(&thr, NULL, thr_futex_wait, NULL);
> -	if (res < 0)
> +	if (res)
>  		ksft_exit_fail_msg("pthread_create error\n");

That does not apply on the locking/futex branch of the tip tree. It's
fixed already.

Thanks,

        tglx