Re: [PATCH net-next v3 2/3] dt-bindings: net: wiznet,w5100: add link-gpios
From: Arthur Crépin Leblond
Date: Mon Aug 10 2026 - 10:56:19 EST
On Mon, Aug 10, 2026 at 10:31:50AM +0200, Krzysztof Kozlowski wrote:
On 10/08/2026 10:25, Arnd Bergmann wrote:
On Mon, Aug 10, 2026, at 10:21, Krzysztof Kozlowski wrote:
On 10/08/2026 10:12, Arthur Crépin Leblond wrote:
We use this line to detect a link change but don't read its value in
the interrupt handler, we read the i2c PHYCFGR register to get the
link status.
I know, but won't you have soon the same problem with active? Otherwise
are you going to keep polling for the active link, since it is not
reported through the main interrupt?
I don't see how we'd ever want to report 'active' state back to
the kernel, this just means it's either receiving or transmitting,
and the kernel already knows when a data transfer happened
because it either started sending or it receives an interrupt for
a received frame.
True, that was just an example so the author thinks about it instead of
just solving one problem now. For example neither speed nor duplex are
reported in the main interrupt and you might need to configure something
if they change.
Best regards,
Krzysztof
I did not want to modify the driver too much and the link status is
enough for me.
Arthur