Re: [PATCH 5/5] sched: pause KCOV in wake_up_new_task()

From: Karl Mehltretter

Date: Mon Aug 10 2026 - 17:58:45 EST


On Sat, Aug 08, 2026 at 02:36:11AM +0100, Bradley Morgan wrote:
> I feel this comment is not the best. I mean, it's more a opinion thing.
>
> /* Instrumented callees would leak into current here... */
>
> could be a good one. What do you think? :)
>

Hi Bradley,

Thank you very much for the review!

I agree, that's a better comment. I will send a v2 series
with guard() soon.

Also Sashiko's review page suggested the new flag bit could cause
a UBSAN issue. That was a false positive, but it showed a
cleanup opportunity: I'm changing the kcov_start() mode parameter
from an enum to unsigned int, since it may contain flag bits.

Thanks,
Karl