Re: [PATCH 07/12] iio: pressure: rohm-bm1390: Fix AVE_NUM initialization

From: Matti Vaittinen

Date: Tue Aug 11 2026 - 05:08:14 EST


On 10/08/2026 23:06, Andy Shevchenko wrote:
On Mon, Aug 10, 2026 at 10:53:07AM +0300, Matti Vaittinen wrote:
From: Matti Vaittinen <mazziesaccount@xxxxxxxxx>

The BM1390 tries to initialize the AVE_NUM to 110b at the start-up. The
field location is not taken into account, and value is written unsifted.
This causes the AVE_NUM to be initialized to zero.

Use FIELD_PREP() to shift the intended AVE_NUM value to correct field.

Can it be FIELD_PREP_CONST()?

Can you please elaborate why it should in this case?

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~