Re: [PATCH v2 4/9] workqueue: account nr_active by the backing pool

From: Breno Leitao

Date: Tue Aug 11 2026 - 06:21:42 EST


On Mon, Aug 10, 2026 at 11:41:23AM -1000, Tejun Heo wrote:
> On Wed, Aug 05, 2026 at 07:52:31AM -0700, Breno Leitao wrote:
> > static struct wq_node_nr_active *wq_node_nr_active(struct workqueue_struct *wq,
> > int node)
> > {
> > - if (!(wq->flags & WQ_UNBOUND))
> > + if (WARN_ON_ONCE(!(wq->flags & WQ_UNBOUND)))
> > return NULL;
>
> This just pushes the crash to the caller, right? Maybe do BUG_ON() instead?

Right. I will do a patch that transform this in BUG_ON() in the next
patchset.


Thanks for the review,
--breno